Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:26, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Mon, 12 Oct 2020 14:04:24 +0000 Henrik Bjoernlund wrote: > > + /* This CCM related status is based on the latest received CCM PDU. */ > > + u8 port_tlv_value; /* Port Status TLV value */ > > + u8 if_tlv_value; /* Interface Status TLV value */ > > + > > + /* CCM has not been received for 3.25 intervals */ > > + bool ccm_defect; > > + > > + /* (RDI == 1) for last received CCM PDU */ > > + bool rdi; > > + > > + /* Indications that a CCM PDU has been seen. */ > > + bool seen; /* CCM PDU received */ > > + bool tlv_seen; /* CCM PDU with TLV received */ > > + /* CCM PDU with unexpected sequence number received */ > > + bool seq_unexp_seen; > > Please consider using a u8 bitfield rather than a bunch of bools, > if any of this structures are expected to have many instances. > That'd save space. I have changed as requested. -- /Henrik
