Re: [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Oct 2020 14:04:22 +0000 Henrik Bjoernlund wrote:
> +	if (config->mdlevel > 7) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "MD level is invalid");
> +		return -EINVAL;
> +	}
> +	/* The MEP-ID is a 13 bit field in the CCM PDU identifying the MEP */
> +	if (config->mepid > 0x1FFF) {
> +		NL_SET_ERR_MSG_MOD(extack,
> +				   "MEP-ID is invalid");
> +		return -EINVAL;
> +	}

If I'm reading patch 7 correctly these parameters come from netlink,
right? In that case please use the netlink policies to check things
like ranges or correct values.



[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux