On Mon, 12 Oct 2020 14:04:22 +0000 Henrik Bjoernlund wrote: > + if (config->mdlevel > 7) { > + NL_SET_ERR_MSG_MOD(extack, > + "MD level is invalid"); > + return -EINVAL; > + } > + /* The MEP-ID is a 13 bit field in the CCM PDU identifying the MEP */ > + if (config->mepid > 0x1FFF) { > + NL_SET_ERR_MSG_MOD(extack, > + "MEP-ID is invalid"); > + return -EINVAL; > + } If I'm reading patch 7 correctly these parameters come from netlink, right? In that case please use the netlink policies to check things like ranges or correct values.