On Wed, 10 Jun 2020 15:49:18 +0000 "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx> wrote: > Tiezhu Yang had sent out a patch set with a slew of kmod selftest > fixes, and one patch which modified kmod to return 254 when a module > was not found. This opened up pandora's box about why that was being > used for and low and behold its because when UMH_WAIT_PROC is used > we call a kernel_wait4() call but have never unwrapped the error code. > The commit log for that fix details the rationale for the approach > taken. I'd appreciate some review on that, in particular nfs folks > as it seems a case was never really hit before. > > This goes boot tested, selftested with kmod, and 0-day gives its > build blessings. Any thoughts on which kernel version(s) need some/all of these fixes? > drivers/block/drbd/drbd_nl.c | 20 +++++------ > fs/nfsd/nfs4recover.c | 2 +- > include/linux/sched/task.h | 13 ++++++++ > kernel/kmod.c | 5 ++- > kernel/umh.c | 4 +-- > lib/test_kmod.c | 2 +- > net/bridge/br_stp_if.c | 10 ++---- > security/keys/request_key.c | 2 +- > tools/testing/selftests/kmod/kmod.sh | 50 +++++++++++++++++++++++----- I'm not really sure who takes kmod changes - I'll grab these unless someone shouts at me.
