The 04/18/2020 12:01, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 14/04/2020 14:26, Horatiu Vultur wrote: > > Media Redundancy Protocol is a data network protocol standardized by > > International Electrotechnical Commission as IEC 62439-2. It allows rings of > > Ethernet switches to overcome any single failure with recovery time faster than > > STP. It is primarily used in Industrial Ethernet applications. > > > > Based on the previous RFC[1][2][3][4], the MRP state machine and all the timers > > were moved to userspace, except for the timers used to generate MRP Test frames. > > In this way the userspace doesn't know and should not know if the HW or the > > kernel will generate the MRP Test frames. The following changes were added to > > the bridge to support the MRP: > > - the existing netlink interface was extended with MRP support, > > - allow to detect when a MRP frame was received on a MRP ring port > > - allow MRP instance to forward/terminate MRP frames > > - generate MRP Test frames in case the HW doesn't have support for this > > > > To be able to offload MRP support to HW, the switchdev API was extend. > > > > Hi Horatiu, > The set still has a few blocker issues (bisectability, sysfs error return, use of extack) > and a few other cleanup tasks as I've noted in my replies to the respective patches. > I think with those out of the way you can submit it for inclusion. Hi Nik, Thanks for the review. I really need to be more careful with the bisectability. I will update the code based on your comments and then send the patch series again. > > Cheers, > Nik > > > > -- /Horatiu
