On Tue, 27 Aug 2019 at 16:20, Andrew Lunn <andrew@xxxxxxx> wrote: > > > That sounds like a great idea. I was expecting to add this logic in the > > set_rx_mode function of the driver. But unfortunetly, I got the calls to > > this function before the dev->promiscuity is updated or not to get the > > call at all. For example in case the port is member of a bridge and I try > > to enable the promisc mode. > > Hi Horatiu > > What about the notifier? Is it called in all the conditions you need > to know about? > > Or, you could consider adding a new switchdev call to pass this > information to any switchdev driver which is interested in the > information. > > At the moment, the DSA driver core does not pass onto the driver it > should put a port into promisc mode. So pcap etc, will only see > traffic directed to the CPU, not all the traffic ingressing the > interface. If you put the needed core infrastructure into place, we > could plumb it down from the DSA core to DSA drivers. > > Having said that, i don't actually know if the Marvell switches > support this. Forward using the ATU and send a copy to the CPU? What > switches tend to support is port mirroring, sending all the traffic > out another port. A couple of DSA drivers support that, via TC. > But the CPU port is not a valid destination for port mirroring in DSA, I might add. > Andrew Regards, -Vladimir
