On 03/07/2019 17:15, Pablo Neira Ayuso wrote: > Hi, > > I'm planning to revert from nf-next > > da4f10a4265b netfilter: nft_meta: add NFT_META_BRI_PVID support > > because: > > * Nikolay wants us to use the helpers, however, through the existing > approach this creates a dependency between nft_meta and the bridge > module. I think I suggested this already, but it seems there is a > need for nft_meta_bridge, otherwise nft_meta pulls in the bridge > modules as a dependency. > > * NFT_META_BRI_PVID needs to be rename to NFT_META_BRI_IIFPVID. > > * We need new helpers to access this information from rcu path, I'm > attaching a patch for such helper for review. > > so we take the time to get this right :-) > Hi, The plan sounds good to me. I also went over the patch and it looks good. I think it'd be nice if we can get rid of the br_private.h include and make nft_meta (or meta_bridge) use linux/if_bridge.h instead. Having a clear distinction between what is supposed to be exported and what remains internal would be great. I will help out with that. Thanks, Nik
