> -----Original Message----- > From: Stephen Hemminger [mailto:stephen@xxxxxxxxxxxxxxxxxx] > Sent: Thursday, January 17, 2019 1:33 AM > To: wangyunjian <wangyunjian@xxxxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; xudingke <xudingke@xxxxxxxxxx>; > bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx; Nkolay Aleksandrov > <nikolay@xxxxxxxxxxxxxxxxxxx>; Roopa Prabhu > <roopa@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH net v3] net: bridge: Fix ethernet header pointer before > check skb forwardable > > On Wed, 16 Jan 2019 21:04:21 +0800 > wangyunjian <wangyunjian@xxxxxxxxxx> wrote: > > > if (unlikely(netpoll_tx_running(to->br->dev))) { > > + skb_push(skb, ETH_HLEN); > > if (!is_skb_forwardable(skb->dev, skb)) { > > kfree_skb(skb); > > } else { > > - skb_push(skb, ETH_HLEN); > > br_netpoll_send_skb(to, skb); > > } > > return; > > The patch looks correct. > > On minor style issue is that after moving skb_push out of the if statement, > both branches of the statement now contain a single line and therefore the > brackets are no longer necessary. Suprised that checkpatch did not complain > about this. OK, I'll fix it and send the v4 later. Thanks Yunjian
