The Linux bridge seems to not correctly forward double vlan tagged packets added using the tc vlan action. I am using a bridge with two netdevs and on one of them a have the clsact qdisc with tc flower rule adding two vlan tags. ip link add name br0 type bridge vlan_filtering 1 ip link set dev br0 up ip link set dev net0 up ip link set dev net0 master br0 ip link set dev net1 up ip link set dev net1 master br0 bridge vlan add dev net0 vid 100 master bridge vlan add dev br0 vid 100 self bridge vlan add dev net1 vid 100 master tc qdisc add dev net0 handle ffff: clsact tc qdisc add dev net1 handle ffff: clsact tc filter add dev net0 ingress pref 1 protocol all flower \ action vlan push id 10 pipe action vlan push id 100 tc filter add dev net0 egress pref 1 protocol 802.1q flower \ vlan_id 100 vlan_ethtype 802.1q cvlan_id 10 \ action vlan pop pipe action vlan pop When using the setup above the packets coming on net0 get double tagged but the MAC headers gets corrupted when the packets go out of net1. It seems that the second vlan header is not considered in br_dev_queue_push_xmit. The skb data pointer is decremented only by the ethernet header length. This later causes the function validate_xmit_vlan to insert the outer vlan tag behind the inner vlan tag. The inner vlan becomes also part of the source mac address. The first patch fixes the problem described above. The second one fixes similar problem when the tpids of the bridge and the inserted vlan don't match. It fixes again incorrect insertion of the skb vlan into the payload. The two patches seem to fix the problem but I am not sure if this the right way to fix this and if there is any other impact. Zahari Doychev (2): net: bridge: fix tc added QinQ forwarding net: bridge: fix tc added vlan insert as payload net/bridge/br_forward.c | 2 +- net/bridge/br_vlan.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.20.1
