On 2018/12/17 17:51, Nikolay Aleksandrov wrote: > On 17/12/2018 11:46, YueHaibing wrote: >> function br_multicast_toggle now always return 0, >> so the variable 'err' is unneeded. >> Also cleanup dead branch in br_changelink. >> >> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> >> --- >> net/bridge/br_multicast.c | 3 +-- >> net/bridge/br_netlink.c | 4 +--- >> 2 files changed, 2 insertions(+), 5 deletions(-) >> > > That is correct, but in such case just make it void. In net/bridge/br_sysfs_br.c: static ssize_t multicast_snooping_store(struct device *d, struct device_attribute *attr, const char *buf, size_t len) { return store_bridge_parm(d, buf, len, br_multicast_toggle); } and store_bridge_parm need the returned err. > > > >