On 22/11/2018 17:52, Andrew Lunn wrote: >> +void br_boolopt_multi_get(const struct net_bridge *br, >> + struct br_boolopt_multi *bm) >> +{ >> + u32 optval = 0; >> + int opt_id; >> + >> + for (opt_id = 0; opt_id < BR_BOOLOPT_MAX; opt_id++) >> + optval |= (br_boolopt_get(br, opt_id) << opt_id); >> + >> + bm->optval = optval; >> + bm->optmask = 0; > > Maybe set optmask to indicate which bits this kernel supports? > I like the idea, will add for v2. Thanks, Nik > Andrew >