On 15/10/2018 14:00, Li RongQing wrote:
> After per-port vlan stats, vlan stats should be released
> when fail to add vlan
>
> Fixes: 9163a0fc1f0c0 ("net: bridge: add support for per-port vlan stats")
> CC: bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
> cc: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
> CC: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Zhang Yu <zhangyu31@xxxxxxxxx>
> Signed-off-by: Li RongQing <lirongqing@xxxxxxxxx>
> ---
> net/bridge/br_vlan.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
> index 9b707234e4ae..8c9297a01947 100644
> --- a/net/bridge/br_vlan.c
> +++ b/net/bridge/br_vlan.c
> @@ -303,6 +303,10 @@ static int __vlan_add(struct net_bridge_vlan *v, u16 flags)
> if (p) {
> __vlan_vid_del(dev, br, v->vid);
> if (masterv) {
> + if (v->stats && masterv->stats != v->stats)
> + free_percpu(v->stats);
> + v->stats = NULL;
> +
> br_vlan_put_master(masterv);
> v->brvlan = NULL;
> }
>
Thanks,
Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
