On 26/09/18 17:48, Andrew Lunn wrote: > Hi Nikolay > >> struct net_bridge { >> spinlock_t lock; >> spinlock_t hash_lock; >> struct list_head port_list; >> struct net_device *dev; >> struct pcpu_sw_netstats __percpu *stats; >> + unsigned long options; > > Maybe a u32 would be better, so we run out of bits at the same time on > 32 and 64 bit systems? > > Andrew > Bitops operate on an unsigned long, I actually had a BUILD_BUG_ON() for 32 bits initially, but checked other places and they seem to be using it as-is without any checks so I decided to leave it as well (e.g. sock_flags).