On 26/09/18 16:30, Ido Schimmel wrote: > On Wed, Sep 26, 2018 at 03:18:02PM +0300, Nikolay Aleksandrov wrote: >> Further reduce the size of net_bridge with 8 bytes and reduce the number of >> holes in it: >> Before: holes: 5, sum holes: 15 >> After: holes: 2, sum holes: 3 >> >> Also as a bonus we get offload_fwd_mark in the first cache line and remove >> the need to pull the last cache line of net_bridge just for that member in >> fast path (should_deliver -> nbp_switchdev_allowed_egress). > > But nbp_switchdev_allowed_egress() compares with 'offload_fwd_mark' from > 'net_bridge_port', not 'net_bridge'... > ha, right you are! I need to check my glasses :) Anyway, I'll correct my commit message and resend v2. We can leave the net_bridge mark in the end, there're 4 bytes there anyway. I was thinking of net_bridge_port, but that is a different patch-set I have. Apparently I've mixed the commit messages. Thanks!
