From: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> Date: Fri, 20 Jul 2018 17:48:25 +0300 > + spin_lock_bh(&p->br->lock); > + ret = brport_attr->store_raw(p, (char *)buf); > + spin_unlock_bh(&p->br->lock); Please respect the const here. Have the methods do a kstrncup(); ... kfree(); sequence if they have to mangle the contents when there is a newline inside. I know the caller is passing in what was a non-const char pointer, I've looked at the implementation, but it might be that way forever. I looked at all other sysfs writes that need to do this \n --> \0 mangling and they either copy the string first into a static buffer or they do the kstrncup() thing. Thank you.
