On 30/05/18 03:56, Petr Machata wrote: > A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves > initializing a struct switchdev_obj_port_vlan, a piece of code that > repeats on each call site almost verbatim. While in the current codebase > there is just one duplicated add call, the follow-up patches add more of > both add and del calls. > > Thus to remove the duplication, extract the repetition into named > functions and reuse. > > Signed-off-by: Petr Machata <petrm@xxxxxxxxxxxx> > Reviewed-by: Vivien Didelot <vivien.didelot@xxxxxxxxxxxxxxxxxxxx> > --- > net/bridge/br_private.h | 13 +++++++++++++ > net/bridge/br_switchdev.c | 25 +++++++++++++++++++++++++ > net/bridge/br_vlan.c | 26 +++----------------------- > 3 files changed, 41 insertions(+), 23 deletions(-) > Reviewed-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
