Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes: > On Mon, May 28, 2018 at 05:11:04PM +0200, Petr Machata wrote: >> @@ -580,6 +591,9 @@ int br_vlan_add(struct net_bridge *br, u16 vid, u16 flags, bool *changed) >> vg->num_vlans++; >> *changed = true; >> } >> + ret = br_switchdev_port_vlan_add(br->dev, vid, flags); >> + if (ret && ret != -EOPNOTSUPP) >> + return ret; > > We should probably do some error handling instead of returning directly? I missed that, you are right. There's a bunch of mutations in the block above. Thanks, Petr
