On 27/04/18 18:11, Ido Schimmel wrote: > From: Petr Machata <petrm@xxxxxxxxxxxx> > > Add a couple new functions to allow querying FDB and vlan settings of a > bridge. > > Signed-off-by: Petr Machata <petrm@xxxxxxxxxxxx> > Signed-off-by: Ido Schimmel <idosch@xxxxxxxxxxxx> > --- > include/linux/if_bridge.h | 28 ++++++++++++++++++++++++++++ > net/bridge/br_fdb.c | 22 ++++++++++++++++++++++ > net/bridge/br_private.h | 11 +++++++++++ > net/bridge/br_vlan.c | 39 +++++++++++++++++++++++++++++++++++++++ > 4 files changed, 100 insertions(+) > Thanks! This looks good to me although the new exported helpers could've taken both bridge or port and return the result. Usually when adding a port-only functions we name them with nbp_ prefix instead of br_. Anyway this can be done later since the API is internal, Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>