Petr says: When mirroring to a gretap or ip6gretap netdevice, the route that directs the encapsulated packets can reference a bridge. In that case, in the software model, the packet is switched. Thus when offloading mirroring like that, take into consideration FDB, STP, PVID configured at the bridge, and whether that VLAN ID should be tagged on egress. Patch #1 introduces a suite of functions to query various bridge bits of configuration: FDB, VLAN groups, etc. Patches #2 and #3 refactor some existing code and introduce a new accessor function. With patches #4 and #5 mlxsw calls mlxsw_sp_span_respin() on switchdev events as well. There is no impact yet, because bridge as an underlay device is still not allowed. That is implemented in patch #6, which uses the new interfaces to figure out on which one port the mirroring should be configured, and whether the mirrored packets should be VLAN-tagged and how. Petr Machata (6): net: bridge: Publish bridge accessor functions mlxsw: spectrum: Extract mlxsw_sp_stp_spms_state() mlxsw: spectrum_switchdev: Publish two functions mlxsw: spectrum: Register SPAN before switchdev mlxsw: Respin SPAN on switchdev events mlxsw: spectrum_span: Allow bridge for gretap mirror drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 50 +++++----- drivers/net/ethernet/mellanox/mlxsw/spectrum.h | 1 + .../net/ethernet/mellanox/mlxsw/spectrum_span.c | 102 +++++++++++++++++++-- .../net/ethernet/mellanox/mlxsw/spectrum_span.h | 1 + .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 72 ++++++++++++++- .../ethernet/mellanox/mlxsw/spectrum_switchdev.h | 43 +++++++++ include/linux/if_bridge.h | 55 +++++++++++ net/bridge/br_fdb.c | 25 +++++ net/bridge/br_private.h | 17 ++-- net/bridge/br_vlan.c | 32 +++++++ 10 files changed, 356 insertions(+), 42 deletions(-) create mode 100644 drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.h -- 2.14.3
