On 03/10/2018 08:32 AM, Stephen Hemminger wrote:
Yes hardware devices may come it with different default values. But the user experience on Linux needs to be consistent. Instead, it makes more sense to me for each device driver using switchdev to program to the values that it sees in the bridge. Please revise this.
Right, it does change default user view, setting flags instead of querying makes more sense then.
However there is a problem that switchdev may not support all flags that bridge code sets by default. For example, looking at spectrum_switchdev.c, it only advertises support for BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD. Currently, I assume that even though some flags are shown as set by default on a new bridge port, some of them are not actually working in switchdev?
