On Tue, 3 Oct 2017 21:58:53 -0700 David Ahern <dsahern@xxxxxxxxx> wrote: > Pass extack arg to br_add_if. Add messages for a couple of failures > and pass arg to netdev_master_upper_dev_link. > > Signed-off-by: David Ahern <dsahern@xxxxxxxxx> This looks good. You might want to pass the netlink_ext_ack down as an immutable pointer (const). Acked-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>