On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli <f.fainelli@xxxxxxxxx> wrote: > On 08/28/2017 09:22 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> >> >> A few useful tracepoints to trace bridge forwarding >> database updates. >> >> Signed-off-by: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > > Small nit below, but probably not a candidate for a v3 > >> --- > >> + >> + TP_printk("dev %s addr %02x:%02x:%02x:%02x:%02x:%02x vid %u nlh_flags %04x ndm_flags = %02x", > > Small nit, any particular reason why ndm_flags got a special treatment > with an equal character and not the other? > good eyes, thats a typo. I did scan them once and removed the '=' and missed a spot. i will send v3.