On 5/19/17 8:30 PM, Ivan Vecera wrote:
Current bridge code incorrectly handles starting/stopping of hello and
hold timers during STP enable/disable.
1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
transition. The timers are already stopped in NO_STP state so
this is confusing no-op.
2. During USER_STP->NO_STP transition the timers are started. This
does not make sense and is confusion because the timer should not be
active in NO_STP state.
Cc: davem@xxxxxxxxxxxxx
Cc: sashok@xxxxxxxxxxxxxxxxxxx
Cc: stephen@xxxxxxxxxxxxxxxxxx
Cc: bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
Cc: lucien.xin@xxxxxxxxx
Cc: nikolay@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Ivan Vecera <cera@xxxxxxx>
---
net/bridge/br_stp_if.c | 11 -----------
1 file changed, 11 deletions(-)
LGTM, thanks!
Acked-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>
