From: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> Date: Tue, 7 Feb 2017 06:43:23 -0800 > From: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> > > vtbegin should not be NULL in this function, Its already checked by the > caller. > > this should silence the below smatch complaint: > net/bridge/br_netlink_tunnel.c:144 br_fill_vlan_tinfo_range() > error: we previously assumed 'vtbegin' could be null (see line 130) > > net/bridge/br_netlink_tunnel.c > 129 > 130 if (vtbegin && vtend && (vtend->vid - vtbegin->vid) > 0) { > ^^^^^^^ > Check for NULL. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-By: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > Signed-off-by: Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx> Applied.