On 30/08/16 16:56, Stephen Hemminger wrote:
> On Tue, 30 Aug 2016 15:08:58 +0200
> Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> wrote:
>
>> /* br_forward.c */
>> +enum {
>> + BR_PKT_UNICAST,
>> + BR_PKT_MULTICAST,
>> + BR_PKT_BROADCAST
>> +};
>> int br_dev_queue_push_xmit(struct net *net, struct sock *sk, struct sk_buff *skb);
>> void br_forward(const struct net_bridge_port *to, struct sk_buff *skb,
>> bool local_rcv, bool local_orig);
>> int br_forward_finish(struct net *net, struct sock *sk, struct sk_buff *skb);
>> void br_flood(struct net_bridge *br, struct sk_buff *skb,
>> - bool unicast, bool local_rcv, bool local_orig);
>> + int pkt_type, bool local_rcv, bool local_orig);
>
> Why not make pkt_type an enum value, you already have that infrastructure there.
>
> enum br_pkt_type {
> BR_PKT_UNICAST,
> ...
> };
>
> void br_flood(struct net_bridge *br, struct sk_buff *skb,
> enum br_pkt_type pkt_type, ...
>
sure, will change it to enum
v2 coming up
