On Wed, 6 Jul 2016 12:12:21 -0700 Nikolay Aleksandrov <razor@xxxxxxxxxxxxx> wrote: > As was suggested this patch adds support for the different versions of MLD > and IGMP query types. Since the user visible structure is still in net-next > we can augment it instead of adding netlink attributes. > The distinction between the different IGMP/MLD query types is done as > suggested in Section 7.1, RFC 3376 [1] and Section 8.1, RFC 3810 [2] based > on query payload size and code for IGMP. Since all IGMP packets go through > multicast_rcv() and it uses ip_mc_check_igmp/ipv6_mc_check_mld we can be > sure that at least the ip/ipv6 header can be directly used. > > [1] https://tools.ietf.org/html/rfc3376#section-7 > [2] https://tools.ietf.org/html/rfc3810#section-8.1 > > Suggested-by: Linus Lüssing <linus.luessing@xxxxxxxxx> > Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> Looks good to me. Acked-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>