Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Miller <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
From: Kees Cook <keescook@xxxxxxxxxxxx>
Date: Tue, 8 Dec 2015 12:56:43 -0800
Cc: "kernel-hardening@xxxxxxxxxxxxxxxxxx" <kernel-hardening@xxxxxxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Network Development <netdev@xxxxxxxxxxxxxxx>
Delivered-to: bridge@xxxxxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20151202.235049.2068953758962834535.davem@davemloft.net>
References: <565B7F7D.80208@nod.at> <CAGXu5jJqQKAmFK0nL69E0QOpo8WSVDqStGZo7-m7gy3vnXBa=A@mail.gmail.com> <87egf7183c.fsf_-_@x220.int.ebiederm.org> <20151202.235049.2068953758962834535.davem@davemloft.net>

On Wed, Dec 2, 2015 at 8:50 PM, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: ebiederm@xxxxxxxxxxxx (Eric W. Biederman)
> Date: Mon, 30 Nov 2015 15:38:15 -0600
>
>> +     if (dev_net(br->dev) == &init_net)
>
> Please respin this using net_eq() as Hannes pointed out.

Sorry if I missed it: this this happen yet?

-Kees

-- 
Kees Cook
Chrome OS & Brillo Security

References:
- user controllable usermodehelper in br_stp_if.c
  - From: Richard Weinberger
- Re: user controllable usermodehelper in br_stp_if.c
  - From: Kees Cook
- [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
  - From: Eric W. Biederman
- Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
  - From: David Miller

Prev by Date: Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
Next by Date: adding a vlan interface to a bridge interface
Previous by thread: Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace
Next by thread: Re: user controllable usermodehelper in br_stp_if.c
Index(es):
- Date
- Thread

[Index of Archives] [Netdev] [AoE Tools] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba] [Video 4 Linux]