Mon, Oct 12, 2015 at 02:41:09PM IDT, razor@xxxxxxxxxxxxx wrote: >From: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx> > >As Ido Schimmel pointed out the vlan_vid_del() loop in nbp_vlan_flush is >unnecessary (and is actually a remnant of the old vlan code) so we can >remove it and combine both br/nbp vlan_flush functions into one. Just a small note to Scott and Vivien: One of the side effects of Nik's recent patchsets is that when VLANs are flushed on a port the deletion is propagated to the driver via switchdev ops, as __vlan_vid_del is called. Therefore there is no need to do internal bookkeeping and remove VLANs yourself when port is removed from bridge. > >Signed-off-by: Nikolay Aleksandrov <nikolay@xxxxxxxxxxxxxxxxxxx>