From: Florian Fainelli <f.fainelli@xxxxxxxxx> Date: Wed, 14 Jan 2015 09:52:11 -0800 > - /* bring loopback device up first */ > + /* bring loopback an DSA master network devices up first */ Typo: "an" should be "and" > - if (dev != ic_dev) { > + /* Only bring down unused devices and not DSA enabled master > + * devices > + */ > + if (dev != ic_dev && !netdev_uses_dsa(dev)) { You don't have to add a comment which just reads the code, I'm a programmer so I am able to do that all on my own :-)