On Fri, Oct 3, 2014 at 6:37 AM, Vlad Yasevich <vyasevic@xxxxxxxxxx> wrote:
> On 10/03/2014 12:41 AM, Cong Wang wrote:
>> On Thu, Oct 2, 2014 at 4:54 PM, Vladislav Yasevich <vyasevich@xxxxxxxxx> wrote:
>>> +static int __br_vlan_set_default_pvid(struct net_bridge *br, u16 pvid)
>>> +{
>>> + struct net_bridge_port *p;
>>> + u16 old_pvid;
>>> + int err;
>>> + DECLARE_BITMAP(changed, BR_MAX_PORTS);
>>
>>
>> This bitmap will use 128 bytes on stack, why not using heap?
>>
>
> I suppose I wanted to avoid yet another memory allocation failure condition.
> Is this really going to cause issues?
>
Probably not a big issue, but generally stack is more limited than heap
in kernel.
