Re: [PATCH net] bridge: Don't include NDA_VLAN for FDB entries with vid 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Toshiaki Makita <makita.toshiaki@xxxxxxxxxxxxx>
Date: Wed, 30 Jul 2014 13:31:51 +0900

> An FDB entry with vlan_id 0 doesn't mean it is used in vlan 0, but used when
> vlan_filtering is disabled.
> 
> There is inconsistency around NDA_VLAN whose payload is 0 - even if we add
> an entry by RTM_NEWNEIGH without any NDA_VLAN, and even though adding an
> entry with NDA_VLAN 0 is prohibited, we get an entry with NDA_VLAN 0 by
> RTM_GETNEIGH.
> 
> Dumping an FDB entry with vlan_id 0 shouldn't include NDA_VLAN.
> 
> Signed-off-by: Toshiaki Makita <makita.toshiaki@xxxxxxxxxxxxx>

This is clearly the right thing to do, since upon FDB addition we reject
NDA_VLAN attributes with value zero.

Applied, thanks.




[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux