Hello. On 05/14/2014 07:09 PM, Vlad Yasevich wrote:
If the user doesn't enable vlan filtering, we have to place all bridge ports in promsic mode so that we retain the capability of of receiving tagged frames. When vlan filtering is enabled, the each port will be provided with necessary vlan configuration and would be able to receive tagged traffic without promiscuous mode set, thus allowing us to automatically turn promiscuity on or off depending on the configuration.
Signed-off-by: Vlad Yasevich <vyasevic@xxxxxxxxxx> --- net/bridge/br_if.c | 12 ++++++++---- net/bridge/br_private.h | 9 +++++++++ net/bridge/br_vlan.c | 1 + 3 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 7759144..a9bf8cc 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -131,12 +131,16 @@ static void br_port_clear_promisc(struct net_bridge_port *p) void br_manage_promisc(struct net_bridge *br) { struct net_bridge_port *p; + int set_all = false;
s/int/bool/? [...] WBR, Sergei