Re: [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery.

[Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>]

On Wed, 14 May 2014 11:09:22 -0400
Vlad Yasevich <vyasevic@xxxxxxxxxx> wrote:

> +void br_port_flags_change(struct net_bridge_port *p, unsigned long old_flags)
> +{
> +	struct net_bridge *br = p->br;
> +	unsigned long mask = old_flags ^ p->flags;
> +
> +	if (!(mask & BR_AUTO_MASK))
> +		return;
> +
> +	nbp_update_port_count(br);
> +}

Minor nit, why have negative logic here.
Instead use:
	if (mask & BR_AUTO_MASK)
		nbp_update_port_count(br);