On 04/28/2014 06:25 PM, Vasily Averin wrote: >>> Therefore I believe that my patch is still correct, however now I think we also need >>> to remove #if IS_ENABLED(CONFIG_NF_CONNTRACK_IPV4) in br_nf_dev_queue_xmit(). >> >> I don't think so, DEFRAG_IPV4 is dependency glue, so it shouldn't be >> possible to build kernel with CONNTRACK_IPV4=n and DEFRAG_IPV4=(m|y). > > Also I believe you are wrong with dependencies: > NF_CONNTRACK_IPV4 forces NF_DEFRAG_IPV4, not vice versa If you do not want to remove this #ifdef at all how do you like an idea to replace NF_CONNTRACK_IPV4 to NF_DEFRAG_IPV4?
