Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp. Cc: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> Cc: David Miller <davem@xxxxxxxxxxxxx> Cc: bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx Cc: netdev@xxxxxxxxxxxxxxx Signed-off-by: Wang Weidong <wangweidong1@xxxxxxxxxx> Signed-off-by: Ding Tianhong <dingtianhong@xxxxxxxxxx> --- net/bridge/br_stp_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index 656a6f3..04217d1 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -229,7 +229,7 @@ bool br_stp_recalculate_bridge_id(struct net_bridge *br) list_for_each_entry(p, &br->port_list, list) { if (addr == br_mac_zero || - memcmp(p->dev->dev_addr, addr, ETH_ALEN) < 0) + !ether_addr_equal_unaligned(p->dev->dev_addr, addr) < 0) addr = p->dev->dev_addr; } -- 1.8.0