Re: [PATCH v3 tip/core/rcu 0/14] Sparse-related updates for 3.13

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 12, 2013 at 07:39:30PM +0200, Hannes Frederic Sowa wrote:
> On Sat, Oct 12, 2013 at 10:13:45AM -0700, Paul E. McKenney wrote:
> > On Fri, Oct 11, 2013 at 11:53:27PM -0700, Josh Triplett wrote:
> > > On Fri, Oct 11, 2013 at 04:16:59PM -0700, Paul E. McKenney wrote:
> > > > Changes from v2:
> > > > 
> > > > o	Switch from rcu_assign_pointer() to ACCESS_ONCE() given that
> > > > 	the pointers are all --rcu and already visible to readers,
> > > > 	as suggested by Eric Dumazet and Josh Triplett.
> > > 
> > > Hang on a moment.  Do *none* of these cases need write memory barriers?
> > 
> > Sigh.  Some afternoons it doesn't pay to touch the keyboard.
> > 
> > Thank you for catching this.  I will fix, but at this point, I am thinking
> > in terms of 3.14 rather than 3.13 for this series.
> 
> Some of them looked safe. You could also replace --rcu with __rcu in the
> comments while at it.

Sigh!  Will do, thank you!

							Thanx, Paul





[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux