This patch has some minor whitespace and spelling errors: WARNING: line over 80 characters #429: FILE: net/bridge/br_private.h:205: +static inline struct net_bridge_port *vlans_to_port(struct net_port_vlans *vlans) ERROR: trailing whitespace #432: FILE: net/bridge/br_private.h:208: + $ WARNING: please, no spaces at the start of a line #432: FILE: net/bridge/br_private.h:208: + $ +/* Must be protected by RTNL */ +static void br_vlan_del(struct net_bridge_vlan *vlan) + /* Drop the self-ref to trigger descrution. */ ^^^^^^^^^^ Also, the data structure vlan's seems inverted. Why do you keep a hash list of vlan's and then a bitmap of ports. Seems more natural to just put a bitmap on each port that has vlan filtering rather than introducing yet another list to manage.