On Fri, 2012-11-30 at 10:18 +0000, Thomas Graf wrote: > On 11/30/12 at 05:58pm, Cong Wang wrote: > > @@ -168,6 +172,8 @@ static const struct nla_policy ifla_brport_policy[IFLA_BRPORT_MAX + 1] = { > > [IFLA_BRPORT_MODE] = { .type = NLA_U8 }, > > [IFLA_BRPORT_GUARD] = { .type = NLA_U8 }, > > [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 }, > > + [IFLA_BRPORT_NO] = { .type = NLA_U16 }, > > + [IFLA_BRPORT_ID] = { .type = NLA_U16 }, > > }; > > > > /* Change the state of the port and notify spanning tree */ > > I missed this in the first round. Not much of a point in adding policy > entries if the attributes are read-only as in this case. Yeah, remove these lines now.