On Wed, Mar 07, 2012 at 10:04:04AM +0200, Paulius Zaleckas wrote: > On 03/06/2012 09:33 PM, David Miller wrote: > > From: Paulius Zaleckas<paulius.zaleckas@xxxxxxxxx> > > Date: Tue, 06 Mar 2012 16:22:19 +0200 > > > >> Now we have: > >> eth0: link *down* > >> br0: port 1(eth0) entering *forwarding* state > >> > >> State should be logged *after* it was changed, not before. > >> > >> Reported-by: Zilvinas Valinskas<zilvinas@xxxxxxxxxxx> > >> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@xxxxxxxxx> > > > > This is intentional, this was a discussion about this. > > > > "Entering" means "about to" therefore we say it before it happens. > > You have missed the whole point here... please look at dmesg output, I > have bolded what you should pay attention to. It should say "entering > disabled state" instead of "entering forwarding state". To make this even more clear so it's not dismissed another time: it says "entering forwarding state" when it is actually entering disabled state. Because the print references the value before the change. Which is changed to disabled just after. Whatever the tense of the verb, it prints the state that's just being left instead of the one being entered. -David
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/bridge
