Hello, Stephen! I can not understand your silence. There are issues fixed by the patch in question. For example, if the interface is left in blocking state after stp was turned off, that state is not stable - it can flip to forwarding state in unpredictable times, e.g. when _any other_ slave of the bridge goes up or down. Do you think user wants exactly that unpredictable state change? Also, the code in question in function br_stp_stop(), namely br_port_state_selection(br) call, does exactly nothing except wasting cpu cycles. Isn't it worth fixing? -- Vitalii Demianets _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/bridge