On Thu, 12 May 2011 17:29:07 +0100 Ben Hutchings <bhutchings@xxxxxxxxxxxxxx> wrote: > > dev->priv_flags |= IFF_BRIDGE_PORT; > > > > - dev_disable_lro(dev); > > - > > list_add_rcu(&p->list, &br->port_list); > > > > - netdev_update_features(br->dev); > > + netdev_change_features(dev); > > > > spin_lock_bh(&br->lock); > > changed_addr = br_stp_recalculate_bridge_id(br); > > Why netdev_change_features() here? I thought that was primarily for use > when vlan_features may have been changed. Setting IFF_BRIDGE_PORT in priv_flags causes change_features to disable LRO. -- _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge