On Wed, Oct 20, 2010 at 11:01 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2010-10-20 at 10:54 +0800, Changli Gao wrote:
>> Signed-off-by: Changli Gao <xiaosuo@xxxxxxxxx>
> []
>> diff --git a/net/appletalk/sysctl_net_atalk.c b/net/appletalk/sysctl_net_atalk.c
>> index 04e9c0d..b92f269 100644
>> --- a/net/appletalk/sysctl_net_atalk.c
>> +++ b/net/appletalk/sysctl_net_atalk.c
>> @@ -42,16 +42,16 @@ static struct ctl_table atalk_table[] = {
>> { },
>> };
>>
>> -static struct ctl_path atalk_path[] = {
>> - { .procname = "net", },
>> - { .procname = "appletalk", },
>> - { }
>> -};
>> -
>> static struct ctl_table_header *atalk_table_header;
>>
>> void atalk_register_sysctl(void)
>> {
>> + const struct ctl_path atalk_path[] = {
>
> Shouldn't all of these be static const struct ?
>
>
They needn't. And some variables are specified __net_initdata currently.
--
Regards,
Changli Gao(xiaosuo@xxxxxxxxx)
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge
