Matt Mackall wrote: > On Mon, 2010-03-22 at 04:17 -0400, Amerigo Wang wrote: >> This whole patchset is for adding netpoll support to bridge and bonding >> devices. I already tested it for bridge, bonding, bridge over bonding, >> and bonding over bridge. It looks fine now. > > Ages ago, Jeff Moyer took a run at this, added him to the cc: on the off > chance he still cares. > >> Please comment. >> >> >> To make bridge and bonding support netpoll, we need to adjust >> some netpoll generic code. This patch does the following things: >> >> 1) introduce two new priv_flags for struct net_device: >> IFF_IN_NETPOLL which identifies we are processing a netpoll; >> IFF_DISABLE_NETPOLL is used to disable netpoll support for a device >> at run-time; > > This one is a little worrisome. I've tried to keep the netpoll code > restricted to as tight an area as possible. Adding new flags like these > that random drivers might try to fiddle with seems like a good way for a > driver writer to get in trouble. Also flag space is filling up. Somewhat, but currently I don't have other way to replace this. Any suggestions? > >> 2) introduce three new methods for netdev_ops: >> ->ndo_netpoll_setup() is used to setup netpoll for a device; >> ->ndo_netpoll_xmit() is used to transmit netpoll requests; >> ->ndo_netpoll_cleanup() is used to clean up netpoll when a device is >> removed. > > Seems like a lot of interface for something to be used by only a couple > core drivers. Hopefully Dave has an opinion here. > Yeah, I worry about this too, maybe we can group those methods for netpoll together into another struct, and just put a pointer here? Thanks! _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge
