Wed, Apr 15, 2009 at 12:13:57PM CEST, kaber@xxxxxxxxx wrote: > David Miller wrote: >> From: Eric Dumazet <dada1@xxxxxxxxxxxxx> >> Date: Wed, 15 Apr 2009 11:27:50 +0200 >> >>> Since you obviously need a write lock here to be sure following >>> can be done by one cpu only. >>> >>> You have same problem all over this patch. >> >> RTNL semaphore is held across all modification operations. > > If this will also be used for multicast lists, changes can happen > (IPv6) without the RTNL. Ok, but for dev_addr_X() functions the RTNL mutex is sufficient so I see no point of adding another lock here. When the multicast handling functions will be implemented to use netdev_hw_addr and it's layer, then we need to use update lock in dev_multicast_X. _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge
