Wed, Apr 15, 2009 at 01:22:32PM CEST, kaber@xxxxxxxxx wrote: > Jiri Pirko wrote: > >>> Since you obviously need a write lock here to be sure following >>> can be done by one cpu only. >>> >>> You have same problem all over this patch. >> >> Yes, as Dave wrote, this is guarded by RTNL mutex. > > This was incorrect. IPv6 adds multicast addresses in softirq context. Yes, I see that. > >>>> + >>>> + ha = kzalloc(sizeof(*ha), GFP_ATOMIC); >>> kzalloc(max(sizeof(*ha), L1_CACHE_SIZE), GFP_...) is thus higly recommended here. >>> >>> Also, why GFP_ATOMIC is needed here ? >> >> Yes, it is not needed here. I've copied it here from the original unicast and >> multicast add funtion to stay close but as I can see, there is no need for it >> there either. >> Noted. > > Also needed for IPv6 in softirq context. > Noted... _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge
