Andy Gospodarek wrote: > On Thu, Jun 12, 2008 at 7:10 AM, Dietmar Maurer <dietmar@xxxxxxxxxxx> wrote: >>>>> There any side effects with the following patch? >>>> Not for you. But if it got changed now, it would surprise the >>>> existing users (change in ABI behaviour). >> If there are no other side effects, I wonder whats better: >> >> A.) unexpected Network failures due to mac changes >> >> B.) surprised users (does anybody depend on such behavour?) >> >> I vote for A.) >> >> - Dietmar >> > > You might think A is a better option, but option B is frowned upon. I > understand you desire your change the behavior to meet your needs, but > Patrick's suggestion to add a module parameter to tweak this behavior > based on a module option is probably better than simply changing the > existing functionality to meet your needs. I actually meant a brctl parameter, module parameters suck as configuration interfaces. But I think the second option is better, just disable this behaviour automatically when the address is configured manually. _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge
