On Tue, 27 Nov 2007 19:12:11 +0300
Pavel Emelyanov <xemul@xxxxxxxxxx> wrote:
> This hook is protected with the RCU, so simple
>
> if (br_should_route_hook)
> br_should_route_hook(...)
>
> is not enough on some architectures.
>
> Use the rcu_dereference/rcu_assign_pointer in this case.
>
> Signed-off-by: Pavel Emelyanov <xemul@xxxxxxxxxx>
>
> ---
>
> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
> index 3cedd4e..b42b192 100644
> --- a/net/bridge/br_input.c
> +++ b/net/bridge/br_input.c
> @@ -122,6 +122,7 @@ static inline int is_link_local(const unsigned char *dest)
> struct sk_buff *br_handle_frame(struct net_bridge_port *p, struct sk_buff *skb)
> {
> const unsigned char *dest = eth_hdr(skb)->h_dest;
> + typeof(br_should_route_hook) rhook;
Okay, but I don't like the typeof() magic. Resubmit with proper declartion.
--
Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/bridge
