On Mon, 15 Oct 2007 23:48:12 +0200 Michał Mirosław <mirq-linux@xxxxxxxxxxxx> wrote: > Quick CPU eater kill. This might be not the best fix possible. > > Without this patch, hello_timer is firing 250 times/sec and eating about > 8% CPU time on my an otherwise idle system (dynticks enabled). 2.6.21.5 was > even worse - 20% (HZ=1000). (br->hello_time was supposedly 0 when STP was > disabled). > > Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> Good idea, but patch needs work. The default hello_time is 2 seconds, so if it is going up to 250/sec then maybe other root bridge is updating it. I don't see where hello_time gets set to 0 if STP disabled? My preference would be to have hello_time set to zero if not running STP and not start timer if it is zero. Also, the check for not sending config BPDU is separate. We do was time deciding to send BPDU when STP is disabled, the existing test could just be moved up the call chain. -- Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx> _______________________________________________ Bridge mailing list Bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/bridge
