Re: [PATCH] bridge: adding new device to bridge should enable if up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>
Date: Wed, 7 Mar 2007 16:03:55 -0800

> One change introduced by the workqueue removal patch is that adding an
> interface that is up to a bridge which is also up does not ever call
> br_stp_enable_port(), leaving the port in DISABLED state until we do
> ifconfig down and up or link events occur.
> 
> The following patch to the br_add_if function fixes it.
> This is a regression introduced in 2.6.21.
> 
> Submitted-by: Aji_Srinivas@xxxxxxx
> Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxxxxxxxxxxxxxx>

Applied, but:

> +	if ((dev->flags & IFF_UP) && netif_carrier_ok(dev) &&
> +	    (br->dev->flags & IFF_UP)) 

I had to fix up the trailing whitespace on that second line.

Please use "git apply --check --whitespace=error-all"
or similar to validate the patches you send me.

Thanks.
_______________________________________________
Bridge mailing list
Bridge@xxxxxxxxxxxxxx
https://lists.osdl.org/mailman/listinfo/bridge


[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux