On Thu, 12 Oct 2006 16:10:44 -0400 Andy Gospodarek <andy at greyhouse.net> wrote: > On Thu, Oct 12, 2006 at 11:24:31AM -0700, Stephen Hemminger wrote: > > Flush the forwarding table when carrier is lost. This helps for > > availability because we don't want to forward to a downed device and > > new packets may come in on other links. > > > > Signed-off-by: Stephen Hemminger <shemminger at osdl.org> > > > > Stephen, > > This is an excellent idea and all looks good except this check > > + if (f->is_static & !do_all) > + continue; > > should be this: > > + if (f->is_static && !do_all) > + continue; > Agreed, but it probably worked during testing because both flags are strict booleans (ie 0/1) -- Stephen Hemminger <shemminger at osdl.org>
