Hi Tejun,
On Wed, Apr 29, 2015 at 4:45 PM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2196,6 +2227,7 @@ out:
> */
> void console_unlock(void)
> {
> + static char ext_text[CONSOLE_EXT_LOG_MAX];
Can you please
a) make this feature optional,
b) (de)allocate this buffer dynamically when the first/last console with
CON_EXTENDED set is (un)registered?
Your patch is at the top of the bloat-o-meter output (against v4.1):
add/remove: 388/154 grow/shrink: 1309/269 up/down: 92366/-44878 (47488)
function old new delta
ext_text - 8192 +8192
do_con_trol - 4824 +4824
path_openat 1416 4224 +2808
tvec_bases 4 2080 +2076
ip_do_fragment - 1824 +1824
unix_stream_read_generic - 1452 +1452
ext4_ext_shift_extents - 1350 +1350
ext4_insert_range - 1174 +1174
bpf_prepare_filter 264 1430 +1166
proc_pid_cmdline_read - 1020 +1020
and unlike the others, this one is not that difficult to fix.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-embedded" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
